You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While f was already implemented, this PR implements the rest of them.
Rather than adding Motion::FindBack, FindTo, and FindToBack, I modified Motion::Find to be Find { ch: char, back: bool, to: bool }, and updated the appropriate logic.
So it seems like, for some reason, the f keybinding and siblings aren't getting parsed properly. I checked the grammar, and the only valid search characters are alphabetical, which is clearly incorrect. Fixing the issue gives me a confusing LALRPOP error that doesn't make sense to me. I'm just going to say for now that this probably does what's intended, but a new issue should be made regarding f that blocks this.
That doesn't fix the issue that it doesn't seem to be parsing correctly anyways, regardless of what character you search for. When you press f, it eats all inputs without doing anything, until you hit escape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
fwas already implemented, this PR implements the rest of them.Rather than adding
Motion::FindBack,FindTo, andFindToBack, I modifiedMotion::Findto beFind { ch: char, back: bool, to: bool }, and updated the appropriate logic.